Comments on: phpArmory – What features do you want to see?

By: Jeroen Janssen

Jeroen Janssen — Tue, 16 Dec 2008 11:53:06 +0000

What about dungeons/boss information?

i.e. from http://www.wowarmory.com/dungeons.xml it seems you can find out: * what dungeons are there * what bosses are in it * what do they drop etc…

By: Gizzmo’s Blog » Warm and Fuzzy

Gizzmo’s Blog » Warm and Fuzzy — Thu, 11 Dec 2008 07:26:14 +0000

[...] I made this suggestion on his post What features do you want to see? [...]

By: Daniel S. Reichenbach

Daniel S. Reichenbach — Wed, 10 Dec 2008 08:22:41 +0000

@Gizzmo: fixed in this commit.

By: Gizzmo

Gizzmo — Tue, 09 Dec 2008 20:30:09 +0000

Yea, but you want to check if either is not set, because you need both, if for example you have 'curl' turned off you will get the error "Fatal error: Call to undefined function curl_init()" It needs to be:

Is curl off? triggerError() Is xml off? triggerError()

not

Are both curl and xml off? triggerError()

By: Daniel S. Reichenbach

Daniel S. Reichenbach — Tue, 09 Dec 2008 13:15:59 +0000

@Gizzmo: The if statement i s correct. We need both the curl and the xml extension. phpArmory will not work with only one available.

I will add on option to getCharacterData in the next release.

By: Gizzmo

Gizzmo — Mon, 08 Dec 2008 21:06:29 +0000

Bugs or problems:

The first if statement in __construct() needs to be || not && because you want to check if either extension is not loaded, not if both are not loaded.

there is a str_replace() in getCharacterData(), its doing the job of urlencode().

A request:

add an option, or an argument to getCharacterData() to grab or not grab the other pages. ie: "reputation", "skills", "talents", "achievements", "statistics". thats alot of info if all you want is basic character data.

By: Sulli

Sulli — Mon, 08 Dec 2008 19:22:53 +0000

I would love to see this ported to a python API. I code primarily in python/django so thats what I want.

By: Peter

Peter — Mon, 08 Dec 2008 08:37:27 +0000

That is indeed the concept. For a website/administrator it is very troublesome. But so far there hasn't been a better security measurement available to prevent all those account hijackings.

And I had to wait like 4 months also till I could get one. These things are immensely popular.

By: Daniel S. Reichenbach

Daniel S. Reichenbach — Sat, 06 Dec 2008 21:06:57 +0000

The issue I see with the authentication token required is: how should that work on a website?

If I understand the way the token works right, you do have to press a button on the stick to get an auth token, and then pass that to the login form on the site, right?

Now if we have a guild bank, you would only be able to update that guild bank data manually and not automated since you would be required to login to the site with the token. Doesn't sound very comfortable to me, and sadly I can not try or verify if that would work, as I do not have the auth token, sold out in my country.

By: Peter

Peter — Fri, 05 Dec 2008 08:27:15 +0000

Well I am gonna have to take that last comment back. I logged in on the amory today, or at least I tried. And as is clearly for all to see, they have updated the system both in features as in looks, and with the features comes also a new login procedure.

Once logged in you stay logged for two weeks max. Therefor they added the Token security feature now also to the armory. The only one left without the Token is the forums, but seeing everything gets updated for it, I guess its just a matter of time.

Personally I have a second account available without a token, so I could still use the guildbank feature, and I think most webmasters can find a solution to the problem if within the phpArmory Library there is a post option for the 6 digit Token.